Do not call TyCtxt::type_of() on a trait
#14830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issue-14828
branch
from
ff7435d to
b7caa1b
Compare
|
r? @Alexendoo @flip1995 We've had two ICE reported already, maybe we'll need an out-of-cycle sync to fix this if we receive some more. |
Alexendoo
approved these changes
May 18, 2025
Alexendoo
added
the
beta-nominated
|
One more ICE report on nightly Clippy: #14858 |
|
Will do an out-of-cycle sync 👍 |
|
@Alexendoo I am not sure this has reached beta, syncing this to rustc should be enough, or am I missing something? |
|
Just checked: The commit linked above isn't in beta yet. No beta backport necessary. |
flip1995
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
useless_as_ref]: fix ICE on trait methodFixes #14828